refactor(vm): optimize opcode energy cost calculation with BigInteger#6613
Open
yanghang8612 wants to merge 1 commit intotronprotocol:developfrom
Open
refactor(vm): optimize opcode energy cost calculation with BigInteger#6613yanghang8612 wants to merge 1 commit intotronprotocol:developfrom
BigInteger#6613yanghang8612 wants to merge 1 commit intotronprotocol:developfrom
Conversation
Use BigInteger for memory size computation to improve precision and add unit tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| // witness array zero, amount array non-zero | ||
| Program program = mockProgram(0, 0, 64, 1, 0); | ||
| long cost = EnergyCost.getVoteWitnessCost3(program); | ||
| // witnessMemNeeded = 0 (size is zero) |
Contributor
There was a problem hiding this comment.
The unit tests in VoteWitnessCost3Test are well-structured — especially appreciate the overflow boundary coverage in testLargeArrayLengthOverflow and testLargeOffsetOverflow, and the consistency check against cost2 in testConsistentWithCost2ForSmallValues. One minor note: the comment in testZeroLengthOneArray states witnessMemNeeded = 0, but cost3 computes size = 0 * 32 + 32 = 32, which is non-zero — worth clarifying if this is an intentional behavior change from cost2.
kuny0707
requested review from
CodeNinjaEvan and
Federico2014
and removed request for
CodeNinjaEvan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BigIntegerinstead ofDataWordfor memory size computation in energy cost calculation to improve precisionallowTvmOsakaproposal config inVMConfigfor future activation control