Skip to content

Fix AssertionError hashing HTML blocks spread over multiple lines (#686) #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicholasserra merged 2 commits into from
Mar 12, 2026
+9 −2
Merged

Fix AssertionError hashing HTML blocks spread over multiple lines (#686) #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b36444c
Fix #686
Crozzers Mar 11, 2026
a53a611
Update changelog
Crozzers Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## python-markdown2 2.5.6 (not yet released)

(nothing yet)
- [pull #687] Fix AssertionError hashing HTML blocks spread over multiple lines (#686)


## python-markdown2 2.5.5
Expand Down
2 changes: 1 addition & 1 deletion lib/markdown2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,7 +922,7 @@ def _hash_html_block_sub(
tag = None

if not tag:
m = re.match(r'.*?<(\S).*?\s*>', html)
m = re.match(r'.*?<(\S).*?\s*>', html, re.S)
# tag shouldn't be none but make the assertion for type checker
assert m is not None
tag = m.group(1)
Expand Down
3 changes: 3 additions & 0 deletions test/tm-cases/hash_html_blocks_issue686.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<p
class="abc">test
</p>
1 change: 1 addition & 0 deletions test/tm-cases/hash_html_blocks_issue686.tags
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
issue686 assertionerror
3 changes: 3 additions & 0 deletions test/tm-cases/hash_html_blocks_issue686.text
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<p
class="abc">test
</p>
Loading