Centralize test file paths for downstream packagers#689
Merged
Conversation
jlizen
changed the title
jplatte
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #541
Motivation
Downstream packagers (Debian, Fedora) need to patch test file paths when the test fixtures live in a different location than the source tree.
Solution
Centralizes only the filesystem paths that packagers actually need to patch into constants at the top of each test module:
TEST_FILES_DIR("../test-files")README_PATH("../README.md")REPO_ROOT("..") in serve_dir/tests.rs onlyEverything else (header names, MIME types, URI paths, expected content strings) stays inline for readability.
Also normalizes the precompressed test file content to a consistent "Test file\n" (10 bytes) across
precompressed.txt,missing_precompressed.txt, andonly_gzipped.txt.gz, with all compressed variants regenerated. This simplifies the assertions and makes the test fixtures self-consistent.Testing
Manually verified all compressed variants round-trip correctly (decompress to expected content). Tests still pass, also.