challenge additions to platform ui for ai arena by jpeg22 · Pull Request #1552 · topcoder-platform/platform-ui

jpeg22 · 2026-03-25T12:54:26Z

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/

What's in this PR?

These are the management pages for the AI arena problem library, tournament manager, and tournament launcher.
It looks like reports is a recent update I din't have in this branch (see last file)

jmgasper

I can't run this because the craco.config.js file update broke the build:

platform-ui ai_arena_march_2026 ❯ yarn start
yarn run v1.22.22
$ bash start.sh
$ craco start --mode ${LOGICAL_ENV:-dev}
/home/jmgasper/Documents/Git/v6/platform-ui/craco.config.js:68



SyntaxError: Unexpected end of input
    at wrapSafe (node:internal/modules/cjs/loader:1512:18)
    at Module._compile (node:internal/modules/cjs/loader:1534:20)
    at Object..js (node:internal/modules/cjs/loader:1699:10)
    at Module.load (node:internal/modules/cjs/loader:1313:32)
    at Function._load (node:internal/modules/cjs/loader:1123:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
    at Module.require (node:internal/modules/cjs/loader:1335:12)
    at module.exports (/home/jmgasper/Documents/Git/v6/platform-ui/node_modules/import-fresh/index.js:33:91)
    at loadJs (/home/jmgasper/Documents/Git/v6/platform-ui/node_modules/cosmiconfig/dist/loaders.js:16:18)

Node.js v22.13.0
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I got really confused by the way this change was first shown in Devin last commit so I'm committing it as recommended in the github UI Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

jmgasper

Still not working:

platform-ui ai_arena_march_2026 ❯ yarn start
yarn run v1.22.22
$ bash start.sh
$ craco start --mode ${LOGICAL_ENV:-dev}
/home/jmgasper/Documents/Git/v6/platform-ui/craco.config.js:50
    webpack: {
           ^

SyntaxError: Unexpected token ':'
    at wrapSafe (node:internal/modules/cjs/loader:1512:18)
    at Module._compile (node:internal/modules/cjs/loader:1534:20)
    at Object..js (node:internal/modules/cjs/loader:1699:10)
    at Module.load (node:internal/modules/cjs/loader:1313:32)
    at Function._load (node:internal/modules/cjs/loader:1123:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
    at Module.require (node:internal/modules/cjs/loader:1335:12)
    at module.exports (/home/jmgasper/Documents/Git/v6/platform-ui/node_modules/import-fresh/index.js:33:91)
    at loadJs (/home/jmgasper/Documents/Git/v6/platform-ui/node_modules/cosmiconfig/dist/loaders.js:16:18)

Node.js v22.13.0
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

jpeg22 · 2026-03-26T06:05:55Z

I’m gonna have to look at it. I think the Devin comments are not right for this file.

…

On Thu, Mar 26, 2026 at 2:04 AM Justin Gasper ***@***.***> wrote: ***@***.**** commented on this pull request. Still not working: platform-ui ai_arena_march_2026 ❯ yarn start yarn run v1.22.22 $ bash start.sh $ craco start --mode ${LOGICAL_ENV:-dev} /home/jmgasper/Documents/Git/v6/platform-ui/craco.config.js:50 webpack: { ^ SyntaxError: Unexpected token ':' at wrapSafe (node:internal/modules/cjs/loader:1512:18) at Module._compile (node:internal/modules/cjs/loader:1534:20) at Object..js (node:internal/modules/cjs/loader:1699:10) at Module.load (node:internal/modules/cjs/loader:1313:32) at Function._load (node:internal/modules/cjs/loader:1123:12) at TracingChannel.traceSync (node:diagnostics_channel:322:14) at wrapModuleLoad (node:internal/modules/cjs/loader:217:24) at Module.require (node:internal/modules/cjs/loader:1335:12) at module.exports (/home/jmgasper/Documents/Git/v6/platform-ui/node_modules/import-fresh/index.js:33:91) at loadJs (/home/jmgasper/Documents/Git/v6/platform-ui/node_modules/cosmiconfig/dist/loaders.js:16:18) Node.js v22.13.0 error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. — Reply to this email directly, view it on GitHub <#1552?email_source=notifications&email_token=AXO56SM7RINDPPRODJ7KEP34STB55A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBRGE3DKNBVG44KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2L24DSL5ZGK5TJMV3V63TPORUWM2LDMF2GS33OONPWG3DJMNVQ#pullrequestreview-4011654578>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXO56SP76YVI6QP6MQHNFQL4STB55AVCNFSM6AAAAACW63CSJ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DAMJRGY2TINJXHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

kkartunov

@jpeg22 please fix the issues outlined by Devin & Copilot. Do not just mark them as resolved but fix or post comments with reasoning.

jpeg22 · 2026-03-26T15:43:27Z

I did

…

On Thu, Mar 26, 2026 at 6:33 AM Kiril Kartunov ***@***.***> wrote: ***@***.**** requested changes on this pull request. @jpeg22 <https://github.com/jpeg22> please fix the issues outlined by Devin & Copilot. Do not just mark them as resolved but fix or post comments with reasoning. — Reply to this email directly, view it on GitHub <#1552?email_source=notifications&email_token=AXO56SJOUKTHT4O2WVTDZI34SUBRLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBRGI4TMOJXGE32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJPLQOJPXEZLWNFSXOX3ON52GSZTJMNQXI2LPNZZV6Y3MNFRWW#pullrequestreview-4012969717>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXO56SIZRQMNT45WO7OTJOT4SUBRLAVCNFSM6AAAAACW63CSJ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DAMJSHE3DSNZRG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

jpeg22 · 2026-03-26T17:56:02Z

On this particular issue, Devin believed we should have a v6 path element and it suggested a commit that didn’t seem to have correct syntax so I made my own change. Tha appears to have been missing a } so when Devin flagged it again, I committed Devin’s suggestion, but that also had a syntax error, so I’ve manually updated it. On Thu, Mar 26, 2026 at 11:43 AM Adam Meikle ***@***.***> wrote:

…

I did On Thu, Mar 26, 2026 at 6:33 AM Kiril Kartunov ***@***.***> wrote: > ***@***.**** requested changes on this pull request. > > @jpeg22 <https://github.com/jpeg22> please fix the issues outlined by > Devin & Copilot. Do not just mark them as resolved but fix or post comments > with reasoning. > > — > Reply to this email directly, view it on GitHub > <#1552?email_source=notifications&email_token=AXO56SJOUKTHT4O2WVTDZI34SUBRLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBRGI4TMOJXGE32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJPLQOJPXEZLWNFSXOX3ON52GSZTJMNQXI2LPNZZV6Y3MNFRWW#pullrequestreview-4012969717>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AXO56SIZRQMNT45WO7OTJOT4SUBRLAVCNFSM6AAAAACW63CSJ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DAMJSHE3DSNZRG4> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

jpeg22 · 2026-03-26T18:23:00Z

Can't add comments to individual Devin recs (No access to GitHub's topcoder platform through Devin with my handle), so here they are:

Exported arena manager routes in platform.routes.tsx, as recommended by Devin
Fixed syntax error in craco (not yet committed)
handleRoundProblemSelection issue is working acceptably for this version
generateDraftTournament doesn't reduce entrants when advancingContestants >= maxContestantsPerMatch
-This will be resolved in defect resolution challenge

Investigating lazy loading comment and comment about the v6 path in craco

jpeg22 · 2026-03-28T04:01:33Z

Okay, fixes in, but I'd like your feedback on the lazy loading comment, @jmgasper ready for re-review

devin-ai-integration

Devin Review found 1 new potential issue.

View 10 additional findings in Devin Review.

devin-ai-integration · 2026-03-28T04:07:41Z

src/apps/arena-manager/src/tournaments/TournamentPage/TournamentPage.tsx

+        if (
+            !name
+            || !Number.isFinite(numRounds) || numRounds < 1
+            || !Number.isFinite(initialEntrants) || initialEntrants < 2
+            || !Number.isFinite(maxContestantsPerMatch) || maxContestantsPerMatch < 2
+            || !Number.isFinite(advancingContestants) || advancingContestants < 1
+        ) {


🟡 Missing validation allows advancingContestants >= maxContestantsPerMatch, producing non-converging tournament brackets

The validation in handleCreate (src/apps/arena-manager/src/tournaments/TournamentPage/TournamentPage.tsx:204-210) checks advancingContestants < 1 and maxContestantsPerMatch < 2, but never enforces advancingContestants < maxContestantsPerMatch. This allows logically impossible configurations — e.g., maxContestantsPerMatch=2, advancingContestants=3 means 3 players advance from a 2-player match. The generateDraftTournament function at line 80 computes currentEntrants = matchesInRound * config.advancingContestants, which causes the entrant count to grow each round instead of converging toward a winner. The loop is bounded by numRounds so it won't hang, but it produces a nonsensical bracket that grows in size each round (e.g., 8 → 12 → 18 → …).

Suggested change

if (

!name

|| !Number.isFinite(numRounds) || numRounds < 1

|| !Number.isFinite(initialEntrants) || initialEntrants < 2

|| !Number.isFinite(maxContestantsPerMatch) || maxContestantsPerMatch < 2

|| !Number.isFinite(advancingContestants) || advancingContestants < 1

) {

if (

!name

|| !Number.isFinite(numRounds) || numRounds < 1

|| !Number.isFinite(initialEntrants) || initialEntrants < 2

|| !Number.isFinite(maxContestantsPerMatch) || maxContestantsPerMatch < 2

|| !Number.isFinite(advancingContestants) || advancingContestants < 1

|| advancingContestants >= maxContestantsPerMatch

) {

Was this helpful? React with 👍 or 👎 to provide feedback.

challenge additions to platform ui for ai arena

942e766

jpeg22 requested review from jmgasper and kkartunov as code owners March 25, 2026 12:54

jpeg22 assigned jmgasper Mar 25, 2026

This comment was marked as resolved.

Sign in to view

jmgasper changed the base branch from dev to ai-arena-manager March 25, 2026 20:08

kkartunov requested a review from Copilot March 25, 2026 20:08

Copilot started reviewing on behalf of kkartunov March 25, 2026 20:09 View session

This comment was marked as resolved.

Sign in to view

Adam Meikle added 2 commits March 26, 2026 01:24

resolved craco and missing reports and null check

f352e78

corrected lowercase R in Reports

a17d722

This comment was marked as resolved.

Sign in to view

jmgasper requested changes Mar 26, 2026

View reviewed changes

Update craco.config.js

ea90b40

I got really confused by the way this change was first shown in Devin last commit so I'm committing it as recommended in the github UI Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

jmgasper reviewed Mar 26, 2026

View reviewed changes

kkartunov requested changes Mar 26, 2026

View reviewed changes

Adam Meikle added 2 commits March 27, 2026 23:57

updated craco and routes and verified build

4a345e2

manual update to craco verified in build

2b6bc83

devin-ai-integration bot reviewed Mar 28, 2026

View reviewed changes

Conversation

jpeg22 commented Mar 25, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related JIRA Ticket:

What's in this PR?

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

jmgasper left a comment

Choose a reason for hiding this comment

Uh oh!

jmgasper left a comment

Choose a reason for hiding this comment

Uh oh!

jpeg22 commented Mar 26, 2026 via email

Uh oh!

kkartunov left a comment

Choose a reason for hiding this comment

Uh oh!

jpeg22 commented Mar 26, 2026 via email

Uh oh!

jpeg22 commented Mar 26, 2026 via email

Uh oh!

jpeg22 commented Mar 26, 2026

Uh oh!

jpeg22 commented Mar 28, 2026

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jpeg22 commented Mar 25, 2026 •

edited by devin-ai-integration bot

Loading