Fix wrong comment and add assertion#337
Merged
tolik518 merged 3 commits intotolik518:masterfrom Mar 27, 2026
Merged
Conversation
Aras14HD
requested changes
Mar 25, 2026
Collaborator
Aras14HD
left a comment
Aras14HD
left a comment
There was a problem hiding this comment.
Thanks for the correction!
But, I'd rather implement those cases.
On zero it should probably return (0, 0).
And to cover negative numbers, it should just use the absolute for the logarithm.
If you want, you can try to do that. Otherwise I can also do it.
Contributor
Author
OK! |
Aras14HD
reviewed
Mar 26, 2026
Collaborator
Aras14HD
left a comment
Aras14HD
left a comment
There was a problem hiding this comment.
Looks good!
Again thanks for the contribution!
Owner
|
Thanks to both of you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment indicates function will not panic when x is finite. However, when x is not positive it will panic, so I fix the comment to be more complete. What's more, I add an assertion with proper error message.