Various tidy-up changes to Models, Decorators and JSON parse error handling#63
Open
kshepherd wants to merge 11 commits intothe-library-code:mainfrom
Open
Various tidy-up changes to Models, Decorators and JSON parse error handling#63kshepherd wants to merge 11 commits intothe-library-code:mainfrom
kshepherd wants to merge 11 commits intothe-library-code:mainfrom
Conversation
it does support __enter__ and __exit__ but at runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client changes:
sessionas an instance var in clientverboseCLI optiondo_paginateto satisfy static analysis whereselfas first arg is expectedModel changes:
__init__methods with dict get accessors and default valuestypevar as class level hard-coded string on all Models (justification: we have modelled the Python data model on the expected type with that label, we don't want to overwrite it with "whatever comes back from the REST API", unless checking for errors, right?)__all__list