Draft
Conversation
We were only passing testtools to mypy, which meant tests were never getting run through mypy. Fixing this highlights a large number of issues that must be resolved. Signed-off-by: Stephen Finucane <stephen@that.guru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were only passing the
testtoolsdirectory to mypy, which meant thetestsdirectory was never getting checked. Fixing this highlights a large number of issues that must be resolved.This is WIP as there are quite a lot of issues to address 😅
PS: This is a non-trivial amount of work that will likely require some fixes to the type annotation in testtools itself. I'm happy for someone else to take this over as it could be a while before I get to it.