Skip to content

Move Vault test client from node-vault to @litehex/node-vault#1264

Closed
cristianrgreco wants to merge 1 commit intomainfrom
codex/vault-client-migration
Closed

Move Vault test client from node-vault to @litehex/node-vault#1264
cristianrgreco wants to merge 1 commit intomainfrom
codex/vault-client-migration

Conversation

@cristianrgreco
Copy link
Collaborator

Summary

  • move the Vault module test client from node-vault to @litehex/node-vault
  • migrate Vault integration test usage to Client + kv2.write/read
  • update package-lock.json to remove the postman-request/legacy node-vault chain

Why

  • upstream issue: node-vault#272
  • the critical vulnerabilities in that chain have been open for months, even with a PR fix in place upstream

Verification Commands

  • npm run format
  • npm run lint
  • npm run test -- packages/modules/vault/src/vault-container.test.ts
  • npm audit

Test Results

  • packages/modules/vault/src/vault-container.test.ts: 2 passed, 0 failed

Semver Impact

  • patch
  • non-breaking evidence: no public runtime API or exported types changed; only Vault module test dependency and tests were updated

@cristianrgreco cristianrgreco added maintenance Improvements that do not change functionality patch Backward compatible bug fix labels Mar 10, 2026
@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 27b22da
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/69afe96549a76a000863f4ce
😎 Deploy Preview https://deploy-preview-1264--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco
Copy link
Collaborator Author

Closing as duplicate now that #1263 was updated to be the Vault-only migration PR. AGENTS.md guidance changes are tracked separately in #1265.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improvements that do not change functionality patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant