Skip to content

Add Oracle Free module#1242

Merged
cristianrgreco merged 16 commits intotestcontainers:mainfrom
collinmurd:main
Mar 9, 2026
Merged

Add Oracle Free module#1242
cristianrgreco merged 16 commits intotestcontainers:mainfrom
collinmurd:main

Conversation

@collinmurd
Copy link
Contributor

Adds a module for Oracle DB support using oracle free. Follows similar implementation to the existing Java and Python modules, which utilize these images

@netlify
Copy link

netlify bot commented Feb 20, 2026

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 4e7263a
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/69ac47ad07a3e900082ae58d
😎 Deploy Preview https://deploy-preview-1242--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@collinmurd collinmurd marked this pull request as ready for review February 20, 2026 18:03
@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels Feb 22, 2026
@cristianrgreco
Copy link
Collaborator

cristianrgreco commented Feb 22, 2026

Thanks for raising @collinmurd!

Looks like testcontainers-java exports a single OracleContainer module, where you can then use free or XE based on the provided image name:

Let's do the same here. Also update the module name from oraclefree to oracle (npm i @testcontainers/oracle).

@cristianrgreco cristianrgreco added the changes requested PR author must respond to review feedback label Feb 23, 2026
@collinmurd
Copy link
Contributor Author

collinmurd commented Feb 23, 2026

Thanks for raising @collinmurd!

Looks like testcontainers-java exports a single OracleContainer module, where you can then use free or XE based on the provided image name:

Let's do the same here. Also update the module name from oraclefree to oracle (npm i @testcontainers/oracle).

Oracle Free is meant to be the successor to Oracle XE. I haven't found anything that indicates a retirement path from Oracle for XE, but the maintainer for these Oracle images isn't supporting XE anymore.

testcontainers-python only exports an testcontainers[oracle-free] package. I'm thinking we should only export with a Oracle Free module to discourage XE use.

@cristianrgreco
Copy link
Collaborator

Ah I didn't know, makes sense then, please disregard my last comment

@cristianrgreco
Copy link
Collaborator

@collinmurd build failed

@collinmurd
Copy link
Contributor Author

collinmurd commented Mar 2, 2026

@collinmurd build failed

Sorry, totally missed it

Still researching. Tests work locally with Docker so I suspect is a resource thing

@cristianrgreco
Copy link
Collaborator

cristianrgreco commented Mar 3, 2026

I would make the change myself but I don't have write permission. The other modules spin up a container per test to enable running in parallel. The issue here is there's a single container for all the tests, so for example the test which checks the restart kills the container while the other tests are running.

Would you be able to make this last change? Apologies for the back and forth.

@collinmurd
Copy link
Contributor Author

Would you be able to make this last change? Apologies for the back and forth.

No worries! Thanks for catching the restart issue. Oracle is a pretty heavy process, running more than 4 or more containers would exceed my 8GB WSL limit. So I was trying to minimize the number of containers in parallel. This leaves with exactly 3 which should hopefully work on most people's machines.

@cristianrgreco cristianrgreco removed the changes requested PR author must respond to review feedback label Mar 9, 2026
@cristianrgreco
Copy link
Collaborator

Thanks @collinmurd for the PR and your patience with the review!

@cristianrgreco cristianrgreco merged commit 2526634 into testcontainers:main Mar 9, 2026
348 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor Backward compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants