Add Oracle Free module#1242
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for raising @collinmurd! Looks like testcontainers-java exports a single
Let's do the same here. Also update the module name from oraclefree to oracle ( |
Oracle Free is meant to be the successor to Oracle XE. I haven't found anything that indicates a retirement path from Oracle for XE, but the maintainer for these Oracle images isn't supporting XE anymore. testcontainers-python only exports an |
|
Ah I didn't know, makes sense then, please disregard my last comment |
|
@collinmurd build failed |
Sorry, totally missed it Still researching. Tests work locally with Docker so I suspect is a resource thing |
|
I would make the change myself but I don't have write permission. The other modules spin up a container per test to enable running in parallel. The issue here is there's a single container for all the tests, so for example the test which checks the restart kills the container while the other tests are running. Would you be able to make this last change? Apologies for the back and forth. |
No worries! Thanks for catching the restart issue. Oracle is a pretty heavy process, running more than 4 or more containers would exceed my 8GB WSL limit. So I was trying to minimize the number of containers in parallel. This leaves with exactly 3 which should hopefully work on most people's machines. |
|
Thanks @collinmurd for the PR and your patience with the review! |
Adds a module for Oracle DB support using oracle free. Follows similar implementation to the existing Java and Python modules, which utilize these images