Conversation
NewWebhookManagedBy is now generic and takes the object as a second argument; .For() is removed. WithValidator() renamed to WithCustomValidator(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Upgrade go.temporal.io/server from v1.31.0 to v1.32.0-155.0 to match go.temporal.io/api v1.62.11, which sdk v1.43.0 requires. The prior upgrade commit left server at v1.31.0 (built against api v1.62.8) while api and sdk moved to v1.62.11, causing a build failure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
go vet now rejects passing a variable directly as the format string to Eventf. Wrap with "%s" to satisfy the static check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…klog metrics Temporal Cloud now emits temporal_worker_deployment_name and temporal_worker_build_id as separate labels, so the label_replace recording rule and adapter name alias are no longer needed. The adapter queries temporal_cloud_v1_approximate_backlog_count directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…klog metrics Temporal Cloud now emits temporal_worker_deployment_name and temporal_worker_build_id as separate opt-in labels (via params.labels in the scrape config), eliminating the need for label_replace. The recording rule is retained for cardinality reduction — it aggregates temporal_cloud_v1_approximate_backlog_count down to the five labels the HPA needs (adding temporal_task_queue to preserve task queue filtering). The metric is renamed to temporal_approximate_backlog_count. Also adds metrics API key rotation instructions and consolidates helm install/upgrade to helm upgrade --install. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ic image tags - Set WorkerHeartbeatInterval to 5s (was 60s default) so Worker Insights UI updates within seconds during a live rollout demo - Set scaledownDelay=0s, deleteDelay=30s (was 30s/5m) so v1 disappears promptly after traffic drains - Switch helloworld-worker Skaffold profile to WORKER_VERSION env template so `WORKER_VERSION=v1 skaffold run --profile helloworld-worker` tags the image and WorkerDeployment pod spec with the semantic version Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
carlydf
changed the title
carlydf
commented
May 6, 2026
| func (r *WorkerDeployment) SetupWebhookWithManager(mgr ctrl.Manager) error { | ||
| return ctrl.NewWebhookManagedBy(mgr). | ||
| For(r). | ||
| return ctrl.NewWebhookManagedBy(mgr, r). |
Collaborator
Author
There was a problem hiding this comment.
needed by new k8s version
carlydf
commented
May 6, 2026
| For(&WorkerResourceTemplate{}). | ||
| WithValidator(v). | ||
| return ctrl.NewWebhookManagedBy(mgr, &WorkerResourceTemplate{}). | ||
| WithCustomValidator(v). |
Collaborator
Author
There was a problem hiding this comment.
needed by new k8s version
carlydf
commented
May 6, 2026
| sunset: | ||
| scaledownDelay: 30s | ||
| deleteDelay: 5m | ||
| scaledownDelay: 0s |
Shivs11
approved these changes
May 6, 2026
| "external": map[string]interface{}{ | ||
| "metric": map[string]interface{}{ | ||
| "name": "temporal_backlog_count_by_version", | ||
| "name": "temporal_approximate_backlog_count", |
Member
There was a problem hiding this comment.
could we also have a pr description as to why we are changing this value here? (as in like we have our metric have these new sep labels now and we don't need the recording rules)
Contributor
There was a problem hiding this comment.
Agree with @Shivs11 here. This change was a surprise for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Upgrade SDK and server to latest.
Why?
To see demo worker in UI, need at least Go SDK v1.41.0
Checklist
Closes
How was this tested: