Fix async poller workflow slot used#2803
Open
jjaegerman wants to merge 2 commits intotemporalio:masterfrom
Open
Fix async poller workflow slot used#2803jjaegerman wants to merge 2 commits intotemporalio:masterfrom
jjaegerman wants to merge 2 commits intotemporalio:masterfrom
Conversation
|
Jonathan Jaegerman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
6d7ed63 to
e510a14
Compare
e510a14 to
5c8fce6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
AsyncWorkflowPollTaskcallsmarkSlotUsedon theSlotSupplierwhen a task is receivedWhy?
WorkflowPollTaskbut missing inAsyncWorkflowPollTaskTrackingSlotSupplier'susedSlotsgets updated whenPollerBehaviorAutoscalingis enabledusedSlotsis used to reportWORKER_TASK_SLOTS_AVAILABLEWORKER_TASK_SLOTS_AVAILABLEvalue problem described in the issue whenPollerBehaviorAutoscalingis enabledNote:
markSlotUsedis handled by the worker Implementation for Activity and Nexus paths (instead of the poll task)WorkflowPollTasktoWorkflowWorkerbecauseWorkflowWorkercannot easily determine if the task is the result of a poll to a sticky task queue or normal task queue (needed for thefromStickyQueuefield)Checklist
Closes #2802
How was this tested: New SlotSupplierTest covers this case (this is where the equivalent synchronous
WorkflowPollTaskbehavior is tested)Any docs updates needed?
No