feat(base): add toolchain installs to base image for volume-mount architecture#24
Merged
feat(base): add toolchain installs to base image for volume-mount architecture#24
Conversation
shekohex
previously requested changes
Mar 7, 2026
GITHUB_TOKEN concern is unwarranted. The content of the github block is actually creating a script that is fully isolated within the created container and uses the user's config value
shekohex
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves all toolchain installs from the now-deleted
Dockerfile.layerinto the shared base image (base-system.Dockerfile). This supports the new volume-mount architecture where the sidecar and shared code are bind-mounted at runtime instead of baked into 82+ layered images.unzip,ripgrepsystem packages; pinnode-pty@1.0.0GITHUB_TOKEN-based auth/sidecarand/sharedmount points with module resolution symlinksCapDrop: ALL)EXPOSE 8080andagent.sidecarlabelsappuser(UID 1001)@webb-tools/tangle-substrate-types)