wrap-java: Fix compilation errors for generic collections#606
Merged
ktoso merged 5 commits intoswiftlang:mainfrom Mar 11, 2026
Merged
wrap-java: Fix compilation errors for generic collections#606ktoso merged 5 commits intoswiftlang:mainfrom
ktoso merged 5 commits intoswiftlang:mainfrom
Conversation
ktoso
reviewed
Mar 11, 2026
| /// ``` | ||
| @JavaMethod | ||
| public func add(_ arg0: JavaObject?) -> Bool | ||
| public func add(_ arg0: E?) -> Bool |
ktoso
reviewed
Mar 11, 2026
| /// ``` | ||
| @JavaMethod | ||
| public func toArray(_ arg0: [JavaObject?]) -> [JavaObject?] | ||
| public func toArray<T: AnyJavaObject>(_ arg0: [T?]) -> [T?] |
ktoso
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the improvements for #599.
It resolves two specific types of compilation errors encountered during code generation.
Fixing these allows for the successful generation of
JavaCollection,JavaSet,Listand other similar types.Error A: Metatype generic parameters
In Swift, generic type parameters cannot be used as macro arguments.
Following existing implementations, I'm using
JavaObjectas a placeholder in those contexts.Error B: Generic parameters in Java arrays
The generic type parameters within Java array types (e.g.,
T[]) were not being correctly detected.