SD-1695 - add flag for text selection in viewing mode#1891
Merged
caio-pizzol merged 16 commits intomainfrom Mar 14, 2026
Merged
SD-1695 - add flag for text selection in viewing mode#1891caio-pizzol merged 16 commits intomainfrom
caio-pizzol merged 16 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3b19fc0cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
caio-pizzol
reviewed
Feb 5, 2026
Contributor
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
nice one @mattConnHarbour!
wonder how we didn't catch this previously
ps. don't forget about allowing keyboard interactions as well
…on-only view mode (SD-1695) - Allow navigation keys (arrows, Home/End, PageUp/PageDown), Cmd+A, and Shift+Arrow in addition to Cmd+C for keyboard accessibility - Block composition events (compositionstart/update/end) to prevent IME input from mutating the document when view.editable is true due to allowSelectionInViewMode - Add unit tests for keyboard allowlist and composition blocking
…editable extension (SD-1695) - Fix missed allowSelectionInViewMode guard in RAF callback that was clearing selection on the next animation frame, defeating the feature - Extract isFullyBlocked() and blockWhenNotEditable() helpers to deduplicate guard logic in editable.js - Hoist navigation keys to module-level NAVIGATION_KEYS Set - Collapse composition event tests into it.each
…1695) - Add allowSelectionInViewMode and documentMode params to behavior test harness and fixture config - Add behavior tests verifying: mouse click + keyboard navigation, Shift+Arrow selection extending, Select All, typing/paste/delete blocked, and selection cleared without the flag
…tations (SD-1695) Keyboard selection extending (Shift+Arrow, Cmd+A) doesn't work in PresentationEditor mode because view.editable is false and PM's editHandlers.keydown doesn't run. Replace those tests with triple-click selection (mouse-based) which works correctly.
…on-only view mode (SD-1695) - Allow navigation keys (arrows, Home/End, PageUp/PageDown), Cmd+A, and Shift+Arrow in addition to Cmd+C for keyboard accessibility - Block composition events (compositionstart/update/end) to prevent IME input from mutating the document when view.editable is true due to allowSelectionInViewMode - Add unit tests for keyboard allowlist and composition blocking
…editable extension (SD-1695) - Fix missed allowSelectionInViewMode guard in RAF callback that was clearing selection on the next animation frame, defeating the feature - Extract isFullyBlocked() and blockWhenNotEditable() helpers to deduplicate guard logic in editable.js - Hoist navigation keys to module-level NAVIGATION_KEYS Set - Collapse composition event tests into it.each
…1695) - Add allowSelectionInViewMode and documentMode params to behavior test harness and fixture config - Add behavior tests verifying: mouse click + keyboard navigation, Shift+Arrow selection extending, Select All, typing/paste/delete blocked, and selection cleared without the flag
…tations (SD-1695) Keyboard selection extending (Shift+Arrow, Cmd+A) doesn't work in PresentationEditor mode because view.editable is false and PM's editHandlers.keydown doesn't run. Replace those tests with triple-click selection (mouse-based) which works correctly.
…' of github.com:Harbour-Enterprises/SuperDoc into caio/sd-1695-add-text-selection-support-in-viewing-mode
Contributor
|
🎉 This PR is included in superdoc v1.18.0-next.58 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-cli v0.2.0-next.133 The release is available on GitHub release |
Collaborator
|
🎉 This PR is included in superdoc v1.19.0 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-cli v0.3.0 The release is available on GitHub release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.