Skip to content

feat: images tests and release on pg 17 and orioledb for multigres#2054

Merged
samrose merged 15 commits intodevelopfrom
multigres-supa-pg
Mar 11, 2026
Merged

feat: images tests and release on pg 17 and orioledb for multigres#2054
samrose merged 15 commits intodevelopfrom
multigres-supa-pg

Conversation

@samrose
Copy link
Collaborator

@samrose samrose commented Feb 17, 2026

New files (2):

  • Dockerfile-multigres-17 — near-identical copy of Dockerfile-17 with 4 changes (no docker-entrypoint.sh, no WAL-G scripts, tail -f /dev/null
    entrypoint, no pgBackRest)
  • Dockerfile-multigres-orioledb-17 — same treatment for the OrioleDB variant

Modified files (4):

  • .github/workflows/docker-image-test.yml — added multigres Dockerfiles to matrix, skip standard tests for them, added smoke test with
    --entrypoint "" override
  • .github/workflows/dockerhub-release-matrix.yml — auto-discovers multigres Dockerfiles, derives -multigres tags from base variant versions
  • .github/workflows/manual-docker-release.yml — same auto-discovery + tag derivation, plus preserves -multigres suffix when
    inputs.postgresVersion is set
  • nix/packages/docker-image-inputs.nix — tracks the two new Dockerfiles in the fileset

Goal, create 2 images that multigres can use to integrate with supabase postgres, and orioledb postgres

@samrose samrose marked this pull request as ready for review February 26, 2026 17:46
@samrose samrose requested review from a team as code owners February 26, 2026 17:46
@samrose samrose force-pushed the multigres-supa-pg branch from 061eacc to b560a19 Compare March 5, 2026 02:09
@cuongdo
Copy link

cuongdo commented Mar 5, 2026

https://github.com/supabase/postgres/actions/runs/22699135346/job/65812194561?pr=2054#step:6:1411

shows that pgbackrest 2.57.0 is being pulled in. Ideally, we'd use 2.58.0, but 2.57.0 is fine. The pgbackrest part specifically looks good to me. I'm not sure how to review the rest.

Copy link

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I have some short questions below for your consideration.

samrose added a commit that referenced this pull request Mar 9, 2026
@samrose samrose force-pushed the multigres-supa-pg branch from 9cfe018 to aada2e1 Compare March 9, 2026 23:38
@cuongdo
Copy link

cuongdo commented Mar 9, 2026

I took another look at this, and this looks like a good starting point for pgctld and pgbackrest. We will have to test and iterate to get things completely right, because Multigres generates Postgres config files based on its own template. We will need to modify the Multigres code to use the Postgres config here as a starting point. This PR looks good from my point of view.

@samrose samrose requested review from deepthi and mkindahl March 10, 2026 00:49
Copy link

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

requires a change to postgresql.conf to set
cron.database_name = 'testing'
*/
-- create extension if not exists pg_cron;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally disabled?

@samrose samrose enabled auto-merge March 11, 2026 18:34
@samrose samrose added this pull request to the merge queue Mar 11, 2026
Merged via the queue into develop with commit 228436b Mar 11, 2026
45 checks passed
@samrose samrose deleted the multigres-supa-pg branch March 11, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants