Merged
Conversation
Full prover is a util to generate an actual proof. While for the rest of the tests the proofs were generated using the `MockProver`
3 tasks
The constants method for the poseidon hasher is necessary for a security standpoint. Adding this method forced the removal of any reference to Generic Field type, that has been replaced with the actual field type that we are using namely bn256
sifnoc
reviewed
May 22, 2023
sifnoc
approved these changes
May 30, 2023
Member
sifnoc
left a comment
There was a problem hiding this comment.
Looks good to me!
Please don't forget to handle https://github.com/summa-dev/merkle-sum-tree-rust after merging this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR introduces some refactoring on the Merkle Sum Tree chip:
assing_leaf_hash_and_balancefunction in the MST chipenforce_less_thanfunction in the MST chipfull_proverandfull_verifierutils. These functions perform a full verification, simulating a production-ready environment. This is compared to all the other tests which are performed using theMockProvermerkle-sum-tree-rustfrom an external repository to an internal module a6cccb9merkle-sum-treein a separate file 2dafd30circuitsin a separate file 166588dmerkle-sum-treeconstructor to prevent creating a tree that will overflow the prime db99ee2constantsmethod for poseidon specifications dfc5d7eswap constraintas it was over constraining the circuit 6c7d2f8