fix: update substrait builder javadoc and spelling#767
Open
mbwhite wants to merge 2 commits intosubstrait-io:mainfrom
Open
fix: update substrait builder javadoc and spelling#767mbwhite wants to merge 2 commits intosubstrait-io:mainfrom
mbwhite wants to merge 2 commits intosubstrait-io:mainfrom
Conversation
mbwhite
force-pushed
the
substrait-builder
branch
from
0ff16d4 to
c55a72d
Compare
bestbeforetoday
requested changes
Mar 19, 2026
Member
bestbeforetoday
left a comment
bestbeforetoday
left a comment
There was a problem hiding this comment.
Looks OK to me, apart from my complaints about misrepresenting this as a fluent builder API in the class doc. Probably just needs those words removed and the test is fine.
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
substrait-builder
branch
from
c55a72d to
5c8fb1c
Compare
Contributor
Author
|
thanks for spotting the incorrect phrasing @bestbeforetoday corrected. I've got some additional methods for this class but wanted to 'tidy' up first. |
mbwhite
force-pushed
the
substrait-builder
branch
2 times, most recently
from
165517b to
e81f09d
Compare
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
Member
|
Just sharing this here in case it was missed In summary is it possible to:
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the JavaDoc for the Substrait Builder (and fix a spelling mistake)
This is ahead of some new functions coming in a follow on pr.