chore: remove unused ESLint directive (#11099)#11100
chore: remove unused ESLint directive (#11099)#11100mvanhorn wants to merge 1 commit intostdlib-js:developfrom
Conversation
…array benchmark The `no-new-wrappers` rule no longer triggers on line 53, making the eslint-disable-line comment unused. This causes a lint error in CI. Fixes stdlib-js#11099 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
kgryte
left a comment
There was a problem hiding this comment.
This looks good; however, we won't be able to merge until the comment above regarding contributing guidelines is resolved.
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage ReportNo coverage information available. |
Summary
Removes an unused
eslint-disable-line no-new-wrappersdirective on line 53 oflib/node_modules/@stdlib/assert/is-nonpositive-number-array/benchmark/benchmark.js. Theno-new-wrappersrule no longer reports on that line, so the disable comment itself causes a lint failure.Changes
One line: removed
// eslint-disable-line no-new-wrappersfrom thenew Number(-1.0)call in the benchmark'screateBenchmarkfunction.Testing
The CI workflow run at https://github.com/stdlib-js/stdlib/actions/runs/23415770324 shows this is the only lint error. Removing the unused directive resolves it.
Fixes #11099
This contribution was developed with AI assistance (Claude Code).