Skip to content

chore: remove unused ESLint directive (#11099)#11100

Open
mvanhorn wants to merge 1 commit intostdlib-js:developfrom
mvanhorn:osc/11099-fix-lint-unused-directive
Open

chore: remove unused ESLint directive (#11099)#11100
mvanhorn wants to merge 1 commit intostdlib-js:developfrom
mvanhorn:osc/11099-fix-lint-unused-directive

Conversation

@mvanhorn
Copy link

Summary

Removes an unused eslint-disable-line no-new-wrappers directive on line 53 of lib/node_modules/@stdlib/assert/is-nonpositive-number-array/benchmark/benchmark.js. The no-new-wrappers rule no longer reports on that line, so the disable comment itself causes a lint failure.

Changes

One line: removed // eslint-disable-line no-new-wrappers from the new Number(-1.0) call in the benchmark's createBenchmark function.

Testing

The CI workflow run at https://github.com/stdlib-js/stdlib/actions/runs/23415770324 shows this is the only lint error. Removing the unused directive resolves it.

Fixes #11099

This contribution was developed with AI assistance (Claude Code).

…array benchmark

The `no-new-wrappers` rule no longer triggers on line 53, making the
eslint-disable-line comment unused. This causes a lint error in CI.

Fixes stdlib-js#11099

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 23, 2026
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; however, we won't be able to merge until the comment above regarding contributing guidelines is resolved.

@kgryte kgryte changed the title fix: remove unused eslint-disable directive in is-nonpositive-number-array benchmark chore: remove unused ESLint directive (#11099) Mar 23, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Mar 23, 2026
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@github-actions github-actions bot mentioned this pull request Mar 23, 2026
@stdlib-bot
Copy link
Contributor

Coverage Report

No coverage information available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants