chore: fix JavaScript lint errors (issue #11082)#11086
chore: fix JavaScript lint errors (issue #11082)#11086fahimlisl wants to merge 1 commit intostdlib-js:developfrom
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
I have read the contributing guidelines and I agree to follow them. |
|
Ref: #11083 |
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
Related Issues
resolves #11082
Description
Fixed a JavaScript linting failure detected in the automated lint
workflow. The
stdlib/no-new-arrayrule disallows use of thenew Array()constructor. Replaced the offending usage indeep_copy.jswith an array literal
[], which is the idiomatic stdlib convention.File changed:
lib/node_modules/@stdlib/utils/copy/lib/deep_copy.jsChange:
```javascript
// Before
ref = ( isArray( x ) ) ? new Array( x.length ) : {};
// After
ref = ( isArray( x ) ) ? [] : {};
```
Checklist