Skip to content

bench: refactor to use string interpolation in blas/ext/base/dcusum#10532

Merged
Planeshifter merged 1 commit intostdlib-js:developfrom
rautelaKamal:bench-dcusum
Feb 27, 2026
Merged

bench: refactor to use string interpolation in blas/ext/base/dcusum#10532
Planeshifter merged 1 commit intostdlib-js:developfrom
rautelaKamal:bench-dcusum

Conversation

@rautelaKamal
Copy link
Contributor

@rautelaKamal rautelaKamal commented Feb 27, 2026

Ref #8647

Description

What is the purpose of this pull request?

This pull request:

  • Refactors the JavaScript benchmarks in @stdlib/blas/ext/base/dcusum to use string interpolation via @stdlib/string/format instead of string concatenation for constructing benchmark names.

Related Issues

This pull request resolves a part of #8647.

Checklist

  • Read, understood, and followed the contributing guidelines
  • Updated JavaScript benchmarks to use @stdlib/string/format.
  • Verified benchmark names are preserved after refactoring.

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Feb 27, 2026
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Feb 27, 2026
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dcusum $\color{green}367/367$
$\color{green}+100.00%$
$\color{green}13/13$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}367/367$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 27, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 27, 2026
@stdlib-bot
Copy link
Contributor

PR Commit Message

bench: refactor to use string interpolation in `blas/ext/base/dcusum`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10532
Ref: https://github.com/stdlib-js/stdlib/issues/8647

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

⚠️ Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

@Planeshifter Planeshifter merged commit c890b1a into stdlib-js:develop Feb 27, 2026
92 of 93 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Feb 27, 2026
Witty-31-06 pushed a commit to Witty-31-06/stdlib that referenced this pull request Mar 7, 2026
PR-URL: stdlib-js#10532
Ref: stdlib-js#8647

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants