Open
Conversation
Verify the full agent forwarding pipeline after the channel request handler fix in #46: one test confirms a forwarded key is visible via ssh-add, the other confirms graceful failure when the client omits the channel handler. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jhrozek
reviewed
Mar 17, 2026
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
lgtm, there is some lint issue that the CI is complaining about plus one question/nit in the tests.
| err = agent.RequestAgentForwarding(session) | ||
| require.NoError(t, err) | ||
|
|
||
| output, err := session.CombinedOutput("ssh-add -l") |
Contributor
There was a problem hiding this comment.
if the test is supposed to be run automatically, we might want to skip it if ssh-add is not available (it is by default on Ubuntu runners in github)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestAgentForwardingEndToEnd: verifies a forwarded ECDSA key is visible viassh-add -lthrough the full client→server→agent proxy pipelineTestAgentForwardingEndToEnd_NoClientHandler: confirms graceful failure when the client doesn't register anauth-agent@openssh.comchannel handlerTest plan
go test -v -race -run TestAgentForwarding ./guest/sshd/task test-nocgo— these tests are linux-only and requiressh-add)🤖 Generated with Claude Code