Skip to content

feat(ske): split options to own subcommand#1313

Merged
rubenhoenle merged 6 commits intomainfrom
feature/list-available-ske-options
Feb 27, 2026
Merged

feat(ske): split options to own subcommand#1313
rubenhoenle merged 6 commits intomainfrom
feature/list-available-ske-options

Conversation

@Manuelvaas
Copy link
Contributor

@Manuelvaas Manuelvaas commented Feb 24, 2026

Description

relates to STACKITCLI-312

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Manuelvaas Manuelvaas marked this pull request as ready for review February 26, 2026 16:50
@Manuelvaas Manuelvaas requested a review from a team as a code owner February 26, 2026 16:50
@rubenhoenle rubenhoenle enabled auto-merge (squash) February 27, 2026 17:36
@rubenhoenle rubenhoenle force-pushed the feature/list-available-ske-options branch from f66b6ac to 00d0a7c Compare February 27, 2026 17:36
@rubenhoenle rubenhoenle merged commit 92c48cb into main Feb 27, 2026
3 checks passed
@rubenhoenle rubenhoenle deleted the feature/list-available-ske-options branch February 27, 2026 17:39
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options 44.06% (+4.36%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/availability_zones 64.86% (+64.86%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/kubernetes_versions 70.21% (+70.21%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/machine_images 73.47% (+73.47%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/machine_types 64.86% (+64.86%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/volume_types 64.86% (+64.86%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/availability_zones/availability_zones.go 64.86% (+64.86%) 37 (+37) 24 (+24) 13 (+13) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/kubernetes_versions/kubernetes_versions.go 70.21% (+70.21%) 47 (+47) 33 (+33) 14 (+14) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/machine_images/machine_images.go 73.47% (+73.47%) 49 (+49) 36 (+36) 13 (+13) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/machine_types/machine_types.go 64.86% (+64.86%) 37 (+37) 24 (+24) 13 (+13) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/options.go 44.06% (+4.36%) 143 (+12) 63 (+11) 80 (+1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/volume_types/volume_types.go 64.86% (+64.86%) 37 (+37) 24 (+24) 13 (+13) 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/availability_zones/availability_zones_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/kubernetes_versions/kubernetes_versions_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/machine_images/machine_images_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/machine_types/machine_types_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/options_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/volume_types/volume_types_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants