Skip to content

fix: olm scripts updates for SDP 26.3 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
razvan wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: olm scripts updates for SDP 26.3 #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions olm/build-manifests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,19 +524,24 @@ def generate_helm_templates(args: argparse.Namespace) -> list[dict]:

def generate_crds(repo_operator: pathlib.Path) -> list[dict]:
logging.debug(f"start generate_crds for {repo_operator}")
crd_path = (
repo_operator / "deploy" / "helm" / repo_operator.name / "crds" / "crds.yaml"
)
cmd = ["cargo", "run", "crd"]
logging.info(f"Running {cmd} in {repo_operator}")
try:
completed_proc = subprocess.run(
cmd,
capture_output=True,
check=True,
cwd=repo_operator,
)
except subprocess.CalledProcessError as e:
logging.error(e.stderr.decode("utf-8"))
raise ManifestException(f'Failed to generate CRDs for "{repo_operator}"')

logging.info(f"Reading CRDs from {crd_path}")
crds = list(yaml.load_all(crd_path.read_text(), Loader=yaml.SafeLoader))
crds = list(yaml.load_all(completed_proc.stdout.decode("utf-8"), Loader=yaml.SafeLoader))
for crd in crds:
if crd["kind"] == "CustomResourceDefinition":
# Remove the helm.sh/resource-policy annotation
del crd["metadata"]["annotations"]["helm.sh/resource-policy"]
else:
if crd["kind"] != "CustomResourceDefinition":
raise ManifestException(
f'Expected "CustomResourceDefinition" but found kind "{crd["kind"]}" in CRD file "{crd_path}"'
f'Expected "CustomResourceDefinition" but found kind "{crd["kind"]}" in CRD output'
)
logging.debug("finish generate_crds")
return crds
Expand Down