Ensure mockOAuth2Login works without springSecurity()#18816
Closed
wonderfulrosemari wants to merge 1 commit intospring-projects:mainfrom
Closed
Ensure mockOAuth2Login works without springSecurity()#18816wonderfulrosemari wants to merge 1 commit intospring-projects:mainfrom
wonderfulrosemari wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: wonderfulrosemari <whwlsgur1419@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
status: blocked
Contributor
|
I'm not convinced that we should make this change, and so I've blocked the PR while discussion continues on #18782 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-18782
Ensure
mockOAuth2Login()works even whenSecurityMockServerConfigurers.springSecurity()has not been explicitlyapplied to
WebTestClient.Previously,
mockOAuth2Login()addedSetupMutatorFilterbut assumedMutatorFilteralready existed. In setups like@SpringBootTest+@AutoConfigureWebTestClient, that assumption can be false, resulting ina missing reactive
SecurityContextand a 401 response.Changes include:
MutatorFilteris present inMutatorWebTestClientConfigurerbefore adding
SetupMutatorFiltermockOAuth2Login()whenspringSecurity()is not explicitly applied