Skip to content

Use immutable map for SEPARATORS static field in DefaultPathContainer #36821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kilink wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −9
Open

Use immutable map for SEPARATORS static field in DefaultPathContainer #36821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions spring-web/src/main/java/org/springframework/http/server/DefaultPathContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
Expand All @@ -42,15 +41,11 @@
*/
final class DefaultPathContainer implements PathContainer {

private static final PathContainer EMPTY_PATH = new DefaultPathContainer("", Collections.emptyList());

private static final Map<Character, DefaultSeparator> SEPARATORS = new HashMap<>(2);

static {
SEPARATORS.put('/', new DefaultSeparator('/', "%2F"));
SEPARATORS.put('.', new DefaultSeparator('.', "%2E"));
}
private static final PathContainer EMPTY_PATH = new DefaultPathContainer("", List.of());

private static final Map<Character, DefaultSeparator> SEPARATORS = Map.of(
'/', new DefaultSeparator('/', "%2F"),
'.', new DefaultSeparator('.', "%2E"));

private final String path;

Expand Down