Add missing null check in ApplicationContextAssertProvider#50456
Open
scordio wants to merge 1 commit into
Open
Add missing null check in ApplicationContextAssertProvider#50456scordio wants to merge 1 commit into
scordio wants to merge 1 commit into
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
scordio
force-pushed
the
missing-null-check
branch
from
11b4b6f to
6a58832
Compare
philwebb
changed the title
ApplicationContextAssertProvider
philwebb
added
type: task
Contributor
Author
|
@philwebb would you like me to rebase this PR onto the |
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
scordio
force-pushed
the
missing-null-check
branch
from
6a58832 to
8453c99
Compare
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a solution for what I mentioned at #40134 (comment), I noticed inconsistencies in the
ApplicationContextAssertProviderTestsmethod names, which led me to spot what I believe is a missing null check forcontextSupplierinApplicationContextAssertProvider.