GH-5340: Use Locale.ROOT in toUpperCase calls for locale-neutral type normalization#6048
Open
suryateja-g13 wants to merge 1 commit into
Open
Conversation
…le-neutral type normalization String.toUpperCase() without a locale is locale-sensitive: on Turkish JVMs (tr_TR) it converts 'integer' to 'İNTEGER', causing Gemini API validation errors because the tool type schema expects strict ASCII enum values (INTEGER, STRING, etc.). Fix all three affected call sites to use toUpperCase(Locale.ROOT) and add a unit test that verifies correctness under the Turkish locale. Signed-off-by: Gorre Surya <suryateja.g13@gmail.com>
suryateja-g13
force-pushed
the
gh-5340-locale-root-toUpperCase
branch
from
8e32bf0 to
a14caba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
String.toUpperCase()without an explicit locale is locale-sensitive. On JVMs with a Turkish locale (tr_TR), it transformsinteger→İNTEGERandstring→STRİNG. This breaks Gemini tool calling because the API expects strict ASCII enum values (INTEGER,STRING, etc.), causing:Three call sites were affected:
JsonSchemaGenerator.convertTypeValuesToUpperCase()— used when building Gemini tool schemasGoogleGenAiTrafficType.from()— used when parsing traffic type metadataGoogleGenAiModalityTokenCount.convertModality()— used when parsing modality token count metadataFix
Replace
.toUpperCase()with.toUpperCase(Locale.ROOT)at all three sites.Locale.ROOTis the correct choice for any case conversion that produces or compares protocol/API strings rather than user-visible text.Test
Added
JsonSchemaGeneratorTests#convertTypeValuesToUpperCaseIsLocaleNeutralwhich temporarily sets the JVM default locale totr_TR, runsconvertTypeValuesToUpperCase, and asserts that the resulting type values are plain ASCII uppercase (OBJECT,INTEGER,STRING).Closes #5340