Skip to content

Generate test app when Milvus and Docker Compose are selected#2122

Open
eddumelendez wants to merge 3 commits intospring-io:mainfrom
eddumelendez:gen-testapp-milvus-compose
Open

Generate test app when Milvus and Docker Compose are selected#2122
eddumelendez wants to merge 3 commits intospring-io:mainfrom
eddumelendez:gen-testapp-milvus-compose

Conversation

@eddumelendez
Copy link
Copy Markdown
Contributor

Milvus Docker Compose Service Connection was added in Spring AI 2.0.0-M3.

Signed-off-by: Eddú Meléndez eddu.melendez@gmail.com

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 18, 2026
Milvus Docker Compose Service Connection was added in Spring AI 2.0.0-M3.

Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
@eddumelendez eddumelendez force-pushed the gen-testapp-milvus-compose branch from c96e96e to 7adb940 Compare March 18, 2026 16:29
@mhalbritter mhalbritter self-assigned this Mar 25, 2026
return DockerService.withImageAndTag("milvusdb/milvus")
.website("https://hub.docker.com/r/milvusdb/milvus")
.randomPort(19530)
.randomPorts(9091, 19530)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this port needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19530 is for GRPC and 9091 is for HTTP. Thought it will be fine to list that port too.

@mhalbritter
Copy link
Copy Markdown
Contributor

I also get this on startup:

Caused by: java.lang.RuntimeException: Failed to initialize connection. Error: UNKNOWN: service unavailable: internal: Milvus Proxy is not ready yet. please wait
        at io.milvus.client.MilvusServiceClient.<init>(MilvusServiceClient.java:191) ~[milvus-sdk-java-2.5.8.jar:na]
        at org.springframework.ai.vectorstore.milvus.autoconfigure.MilvusVectorStoreAutoConfiguration.milvusClient(MilvusVectorStoreAutoConfiguration.java:124) ~[spring-ai-autoconfigure-vector-store-milvus-2.0.0-M3.jar:2.0.0-M3]
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) ~[na:na]
        at java.base/java.lang.reflect.Method.invoke(Method.java:565) ~[na:na]
        at org.springframework.beans.factory.support.SimpleInstantiationStrategy.lambda$instantiate$0(SimpleInstantiationStrategy.java:155) ~[spring-beans-7.0.6.jar:7.0.6]
        ... 37 common frames omitted

Is there a health check missing?

@mhalbritter mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Mar 27, 2026
@eddumelendez
Copy link
Copy Markdown
Contributor Author

Started getting this as well. A healthcheck must be added

    healthcheck:
      test: curl http://127.0.0.1:9091/healthz

I'll submit a PR to initializr.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Mar 27, 2026
@mhalbritter
Copy link
Copy Markdown
Contributor

mhalbritter commented Mar 31, 2026

The initializr PR is merged. Do you want to add the health check or should I take over?

Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
@eddumelendez
Copy link
Copy Markdown
Contributor Author

@mhalbritter PR updated

}

@Bean
@ConditionalOnPlatformVersion("4.1.0-RC1")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.1.0-RC1 isn't out yet. We can target 4.1.0-M4, can't we?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
@mhalbritter mhalbritter added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants