Generate test app when Milvus and Docker Compose are selected#2122
Open
eddumelendez wants to merge 3 commits intospring-io:mainfrom
Open
Generate test app when Milvus and Docker Compose are selected#2122eddumelendez wants to merge 3 commits intospring-io:mainfrom
eddumelendez wants to merge 3 commits intospring-io:mainfrom
Conversation
Milvus Docker Compose Service Connection was added in Spring AI 2.0.0-M3. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
c96e96e to
7adb940
Compare
mhalbritter
reviewed
Mar 27, 2026
| return DockerService.withImageAndTag("milvusdb/milvus") | ||
| .website("https://hub.docker.com/r/milvusdb/milvus") | ||
| .randomPort(19530) | ||
| .randomPorts(9091, 19530) |
Contributor
There was a problem hiding this comment.
Why is this port needed?
Contributor
Author
There was a problem hiding this comment.
19530 is for GRPC and 9091 is for HTTP. Thought it will be fine to list that port too.
Contributor
|
I also get this on startup: Is there a health check missing? |
Contributor
Author
|
Started getting this as well. A healthcheck must be added healthcheck:
test: curl http://127.0.0.1:9091/healthzI'll submit a PR to initializr. |
Contributor
|
The initializr PR is merged. Do you want to add the health check or should I take over? |
Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
Contributor
Author
|
@mhalbritter PR updated |
mhalbritter
reviewed
Mar 31, 2026
| } | ||
|
|
||
| @Bean | ||
| @ConditionalOnPlatformVersion("4.1.0-RC1") |
Contributor
There was a problem hiding this comment.
4.1.0-RC1 isn't out yet. We can target 4.1.0-M4, can't we?
Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milvus Docker Compose Service Connection was added in Spring AI 2.0.0-M3.
Signed-off-by: Eddú Meléndez eddu.melendez@gmail.com