execute: Improve handle handling#38
Merged
scheibelp merged 1 commit intoMay 20, 2026
Merged
Conversation
Go to greather lenghts to ensure handles are not inheritable by the child process, creating inheritable copies and then immediately closing on the parent side. Ensure parent side handles are uninheritable Prevent small race condition by starting reader processes first Ensure better stack saftey with dynamic arrays instead of c style Signed-off-by: John Parent <john.parent@kitware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go to greather lenghts to ensure handles are not inheritable by the child process, creating inheritable copies and then immediately closing on the parent side. Ensure parent side handles are uninheritable
Prevent small race condition by starting reader processes first
Ensure better stack saftey with dynamic arrays instead of c style