Linker Parsing: overhaul rsp pass#37
Merged
Merged
Conversation
We were failing to properly handle rsp files. We should not be handling them as files or storing them, instead we should parse them, extract their contents, parse that as if it was passed on the command line, and then compose that into additional rsp files if neccesary. Before we were just extracting the rsp contents, not parsing them as if they were supplied as part of the cli, which was incorrect. Further, RSP files may be one very long line instead of many lines like how CMake generates them. Handle that case as well. Signed-off-by: John Parent <john.parent@kitware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were failing to properly handle rsp files. We should not be handling them as files or storing them, instead we should parse them, extract their contents, parse that as if it was passed on the command line, and then compose that into additional rsp files if neccesary. Before we were just extracting the rsp contents, not parsing them as if they were supplied as part of the cli, which was incorrect.
Further, RSP files may be one very long line instead of many lines like how CMake generates them. Handle that case as well.