utils.cxx: Saftey improvements#36
Merged
Merged
Conversation
Use dynamic arrays instead of c style arrays for better stack safety Expand conditions for "invalid handles" on handle cleanup to avoid cleaning null handles Add bounds checking for long paths, add error checking for sfn buffer size computation Have debug flush the buffer immediately Make strip paths behave consistently with caller expectations Signed-off-by: John Parent <john.parent@kitware.com>
scheibelp
reviewed
May 20, 2026
| const std::string& old = old_new[0]; | ||
| const std::string& new_ = old_new[1]; | ||
| const std::string& old = strip_padding(old_new[0]); | ||
| const std::string& new_ = strip_padding(old_new[1]); |
Member
There was a problem hiding this comment.
Follow up - determine if both of these need to be stripped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use dynamic arrays instead of c style arrays for better stack safety
Expand conditions for "invalid handles" on handle cleanup to avoid cleaning null handles
Add bounds checking for long paths, add error checking for sfn buffer size computation
Have debug flush the buffer immediately
Make strip paths behave consistently with caller expectations