feat(oauth): Add refresh to oauthdevice.Client#1227
feat(oauth): Add refresh to oauthdevice.Client#1227burmudar wants to merge 2 commits intowb/add-oauth-device-flowfrom
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
keegancsmith
left a comment
There was a problem hiding this comment.
did you test what happens if someone revokes src-cli and then you try refresh a token / use an old token? I'm interested to know if the error message you show users is possible to debug as that being the issue.
Noopee! Def a good call out - I'll make sure to test it |
fd1668e to
1565618
Compare
2f24f44 to
7f2c665
Compare
1565618 to
9a04958
Compare
7f2c665 to
87b5732
Compare
9a04958 to
c1c82ec
Compare
87b5732 to
abd0850
Compare
Tried the above scenario and the only error we get back is "Invalid OAuth Token". We catch it in #1228 and then guide the user to re-run |
add refresh to oauthdevice.Client
oauthdevice: add RefreshToken field and Refresh method
Test plan