Open
Conversation
Add comment-based suppression for unused properties and tests, including JUnit TempDir-based parsing test and Maven inspection suppression. Made-with: Cursor
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| public class UnusedPropertyRule extends AbstractEnforcerRule { | ||
| private static final Pattern PROPERTY_PATTERN = Pattern.compile("\\$\\{([^}]+)\\}"); | ||
| private static final Pattern SUPPRESS_COMMENT = Pattern.compile("<!--\\s*suppress\\s+UnusedProperty\\s*-->", Pattern.CASE_INSENSITIVE); | ||
| private static final Pattern PROPERTY_ELEMENT = Pattern.compile("<([a-zA-Z0-9.-]+)>"); |
Contributor
There was a problem hiding this comment.
🟡 PROPERTY_ELEMENT regex excludes underscores, silently skipping suppression for properties with underscores
The PROPERTY_ELEMENT pattern <([a-zA-Z0-9.-]+)> does not include underscores (_) in the character class. Maven property names commonly contain underscores (e.g., <my_lib.version>). If a user places <!-- suppress UnusedProperty --> before such a property, the suppression will silently fail because the element won't be matched by the regex, and the property will still be reported as unused despite the suppression comment.
Suggested change
| private static final Pattern PROPERTY_ELEMENT = Pattern.compile("<([a-zA-Z0-9.-]+)>"); | |
| private static final Pattern PROPERTY_ELEMENT = Pattern.compile("<([a-zA-Z0-9._-]+)>"); |
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comment-based suppression for unused properties and tests, including JUnit TempDir-based parsing test and Maven inspection suppression.
Made-with: Cursor