Skip to content

Potential fixes for 3 code quality findings#27

Draft
lithium147 wants to merge 5 commits intomainfrom
ai-findings-autofix/src-main-java-com-solubris-enforcer-VersionPropertyRule.java
Draft

Potential fixes for 3 code quality findings#27
lithium147 wants to merge 5 commits intomainfrom
ai-findings-autofix/src-main-java-com-solubris-enforcer-VersionPropertyRule.java

Conversation

@lithium147
Copy link
Collaborator

This PR applies 3/3 suggestions from code quality AI findings.

lithium147 and others added 3 commits March 8, 2026 17:46
…pertyRule.java from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…pertyRule.java from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…pertyRule.java from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Mar 8, 2026

Test Results

37 tests  ±0   37 ✅ ±0   2s ⏱️ -2s
 6 suites ±0    0 💤 ±0 
 6 files   ±0    0 ❌ ±0 

Results for commit 90a3956. ± Comparison against base commit 2e22015.

♻️ This comment has been updated with latest results.

if (implicitVersionCount < artifacts.size()) return unusedProperty(effectiveVersion, artifacts);
} else if (artifacts.size() == 1) {
if (propertyCount == 1) return redundantProperty(artifacts.get(0));
if (implicitVersionCount == 1) return redundantProperty(artifacts.get(0));

Check warning

Code scanning / SonarQube

Merge this if statement with the enclosing one.

Merge this if statement with the enclosing one.
@github-actions
Copy link

🎓   Autograding GitHub Action - 269 of 400 (67%)

Score percentage: 67%

   🚦   JUnit Tests - 0 of 100: 100 % successful (✔️ 49 passed)
   〰️   Line Coverage - 85 of 100: 85% (53 missed lines)
   ➰   Branch Coverage - 69 of 100: 69% (34 missed branches)
   CheckStyle   CheckStyle - 92 of 100: 8 warnings (0 error, 0 high, 3 normal, 5 low)
   PMD   PMD - 100 of 100: No warnings
   SpotBugs   SpotBugs - 100 of 100: No warnings

Created by Autograding v3.19.0 (#ed535be). More details are shown in the GitHub Checks Result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant