Update unit tests for traceflags 02,03#766
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates unit tests to explicitly demonstrate that trace flags 0x02 and 0x03 are treated as valid inputs by the existing SolarWinds APM W3C formatting, propagation injection, and custom sampling override behavior.
Changes:
- Expanded
W3CTransformer.trace_flags_from_intunit test to cover additional flag values including0x02and0x03. - Updated propagator test helpers and added injection tests to verify
-02/-03are preserved in newly createdtracestate. - Added sampler tests to verify
swtracestate decisions-02/-03override contradictory W3Ctrace_flagssampled/default state.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/unit/test_w3c_transformer.py |
Parametrizes trace-flags formatting assertions to cover 00–03 (and a non-trivial hex value). |
tests/unit/test_propagator.py |
Allows mocking non-0x01 trace flags and adds injection tests ensuring -02/-03 are preserved in generated tracestate. |
tests/unit/test_oboe/test_oboe_sampler.py |
Adds sampling tests proving sw tracestate -02/-03 overrides opposing W3C sampled/default flags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates unit test coverage as evidence that traceflags
02,03are valid for existing APM Python custom sampling and propagation logic.See ticket for more background information.