Swap spl-pod for solana-zero-copy + solana-nullable#1069
Draft
Swap spl-pod for solana-zero-copy + solana-nullable#1069
Conversation
grod220
commented
Apr 1, 2026
Comment on lines
+52
to
+58
| /// Convert a legacy ZK SDK ElGamal pod pubkey into the nullable-compatible pod type. | ||
| /// This is temporary until updated solana-zk-sdk crates are published. | ||
| pub fn convert_legacy_elgamal_pubkey( | ||
| pubkey: LegacyPodElGamalPubkey, | ||
| ) -> Result<PodElGamalPubkey, ProgramError> { | ||
| Ok(cast::<LegacyPodElGamalPubkey, PodElGamalPubkey>(pubkey)) | ||
| } |
Member
Author
There was a problem hiding this comment.
This draft PR had to do a good deal of conversions between legacy/new zk types. @samkim-crypto, definitely think it's worth holding this PR until the new crates you are working on are published and applied to this repo.
Contributor
There was a problem hiding this comment.
Yes, the crates are now published and I am in the process of swapping out token-2022. I need to resolve some dependency resolution conflict, but I am making progress and I'll ask for your review when I do 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft attempt at migrating away from
spl-pod. Needs to likely wait until solana-zk-* new crates are published.