chore(ci): Use build image for Linux acceptance test dependencies#6703
Open
chore(ci): Use build image for Linux acceptance test dependencies#6703
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
danskmt
commented
Apr 2, 2026
Comment on lines
-381
to
+386
| # this can be removed if we install the xdg-utils package in the docker image | ||
| # xdg-utils, docker.io, and uv are now pre-installed in the build image (CLI-1403) | ||
| install-deps-linux-acceptance-tests: | ||
| steps: | ||
| - run: | ||
| name: Installing linux acceptance tests dependencies | ||
| command: | | ||
| sudo apt-get update | ||
| sudo apt-get install xdg-utils docker.io -y | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| echo 'export PATH="$HOME/.local/bin:$PATH"' >> $BASH_ENV | ||
| name: No dependencies to install (pre-installed in build image) | ||
| command: echo all done! |
Contributor
Author
There was a problem hiding this comment.
Leave it as a NOOP (current change) or remove it completely?
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Updates CircleCI so Linux docker acceptance jobs no longer install
xdg-utils,docker.io, anduvon every run; those tools are expected to be insnyklabs/cli-build-private/cli-build-private-arm64. Bumps the four docker executor image tags to the build produced after the Dockerfile change, and turnsinstall-deps-linux-acceptance-testsinto a no-op.Where should the reviewer start?
.circleci/config.yml—docker-amd64*,docker-arm64*image tags andinstall-deps-linux-acceptance-testsHow should this be manually tested?
mainwith the new Dockerfile before this merges.mainbranch; they should stay green without the old install step.What's the product update that needs to be communicated to CLI users?
None — CI only.
Risk assessment
Low - must ensure new image tag and noop for old installation step land together.
What are the relevant tickets?
CLI-1403
Related PR and Ticket: #6701 CLI-1443