Extend format check to support fractions#2666
Open
TheLongAndOnly wants to merge 6 commits intosnaptec:masterfrom
Open
Extend format check to support fractions#2666TheLongAndOnly wants to merge 6 commits intosnaptec:masterfrom
TheLongAndOnly wants to merge 6 commits intosnaptec:masterfrom
Conversation
benderl
reviewed
Mar 28, 2023
| @@ -1,5 +1,5 @@ | |||
| #!/bin/bash | |||
| re='^-?[0-9]+$' | |||
| re='^-?[0-9]+(\.[0-9]+)?$' | |||
Collaborator
There was a problem hiding this comment.
Die Anpassung wirkt sich auf alle Prüfungen aus. Mindestens die Leistung muss ein ganzzahliger Wert sein.
Bitte einen separaten regulären Ausdruck definieren und bei Strom und Spannung nutzen.
separate RE für V, A und Pf
benderl
requested changes
Apr 4, 2023
Collaborator
benderl
left a comment
benderl
left a comment
There was a problem hiding this comment.
Bitte die drei angepassten Dateien nochmal prüfen. Warum sind dort unterschiedliche Änderungen drin?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voltage and current readout does not pass the checks before pushed to ramdisk as the status requests returns floats and not integers