Clean up dropped resources in relayer construction#1927
Merged
Conversation
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
📊 API Diff Results
|
jmank88
previously approved these changes
Mar 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent leaked/dropped resources during relayer construction in the LOOP relayer gRPC client/server wiring, supporting LINK-777.
Changes:
- Return accumulated
net.Resources(deps) from relayer/CCIP provider client-connection constructors soclientConn.refreshcan close them on failure. - Fix a server-side resource closer bug where the CSA keystore resource was closing the wrong connection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ogtownsend
commented
Mar 25, 2026
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
approved these changes
Mar 26, 2026
pavel-raykov
approved these changes
Mar 26, 2026
jmank88
deleted the
ogt/clean-up-potential-resource-drops-in-relayer-client
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an apparent memory leak where resources created within the relayer closures are not properly cleaned up when the connection refreshes.