refactor: remove logger from create command by mwbrooks · Pull Request #366 · slackapi/slack-cli

mwbrooks · 2026-03-06T22:52:14Z

Changelog

N/A

Summary

This pull request is part 2 of removing internal/logger package and is focused on the the create command.

The appCreateSpinner is removed because it was never used
- The production code successfully stopped it, but it never started it. Stops are ignored when the spinner has not started.
- The installing dependencies spinner continues to display as it does in production
- I looked into re-adding it, but the spinner but it no longer looks good with our new create UX

Test Steps

$ lack create my-app
# → Select "Starter app"
# → Select "Bolt for Python"
# → Confirm spinner displayed when installing dependencies
# → Confirm all output looks as expected

# Cleanup
$ rm -rf my-app/

Requirements

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

codecov · 2026-03-06T22:55:52Z

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.21%. Comparing base (008e166) to head (7395088).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/pkg/create/create.go	33.33%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   65.09%   65.21%   +0.12%     
==========================================
  Files         216      216              
  Lines       18082    18026      -56     
==========================================
- Hits        11770    11756      -14     
+ Misses       5222     5179      -43     
- Partials     1090     1091       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mwbrooks

Comments for the patient reviewers 🙇🏻

mwbrooks · 2026-03-06T22:53:06Z

.claude/CLAUDE.md

+### Formatting
+
+Always run `gofmt -w` on changed Go files after making edits to ensure proper formatting.
+


note: Just adding this to scratch an itch where Claude fails to format files correctly.

mwbrooks · 2026-03-06T22:53:27Z

cmd/project/create.go

-var appCreateSpinner *style.Spinner
-
-const copyTemplate = "Copying"
-const cloneTemplate = "Cloning"
-


note: Removing because the spinner was never started in the current code.

mwbrooks · 2026-03-06T22:54:02Z

cmd/project/create.go

-			case "on_app_create_template_default":
-				printAppCreateDefaultemplate(cmd, event)
-			case "on_app_create_template_custom":
-				printAppCreateCustomTemplate(cmd, event)


note: Neither of these events were ever called. This is why the spinner was never started.

mwbrooks · 2026-03-06T22:54:35Z

cmd/project/create.go

-			case "on_app_create_completion":
-				printProjectCreateCompletion(clients, cmd, event)


note: This event was correctly called, but the spinner was never started so any calls to stop it are ignored.

⭐ praise: @mwbrooks This is upsetting to find! I'm sure these codeblocks have sent others down a rabbit hole before... Let's keep things simple! Thanks for these changes.

@zimeg Totally agree, I imagine others have followed this logic and weaved their changes into it. It would have been very difficult to debug only to realize that the code is never actually executed. 😢

mwbrooks · 2026-03-06T22:56:31Z

internal/pkg/create/create.go

-	// Notify listeners
-	log.Log("info", "on_app_create_template")


note: This event name doesn't exist 🤦🏻 It should have been on_app_create_template_[default|custom].

zimeg

@mwbrooks LGTM! I left a comment of anguish to learn of uncalled code around 👁️‍🗨️ ✨

zimeg · 2026-03-09T22:18:34Z

cmd/project/create.go

-			case "on_app_create_completion":
-				printProjectCreateCompletion(clients, cmd, event)


⭐ praise: @mwbrooks This is upsetting to find! I'm sure these codeblocks have sent others down a rabbit hole before... Let's keep things simple! Thanks for these changes.

The Create mock was called with 4 argument matchers but the function only accepts 3 parameters (ctx, clients, createArgs).

mwbrooks · 2026-03-09T23:40:37Z

Thanks again for the review @zimeg! 🎉

It looks like the create command is ready to be merged free from the package logger! 🚀

mwbrooks added 2 commits March 6, 2026 14:49

refactor: remove logger from project create

e3279b8

refactor: remove unused spinner in create

6149149

mwbrooks self-assigned this Mar 6, 2026

mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Mar 6, 2026

mwbrooks added this to the Next Release milestone Mar 6, 2026

mwbrooks commented Mar 6, 2026

View reviewed changes

mwbrooks marked this pull request as ready for review March 6, 2026 22:59

mwbrooks requested a review from a team as a code owner March 6, 2026 22:59

zimeg approved these changes Mar 9, 2026

View reviewed changes

mwbrooks added 2 commits March 9, 2026 16:20

Merge branch 'main' into mwbrooks-chopping-the-log-2

a90fc9c

fix: correct mock argument count in charm create test

7395088

The Create mock was called with 4 argument matchers but the function only accepts 3 parameters (ctx, clients, createArgs).

mwbrooks merged commit 0d9a1e2 into main Mar 9, 2026
7 checks passed

mwbrooks deleted the mwbrooks-chopping-the-log-2 branch March 9, 2026 23:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove logger from create command#366

refactor: remove logger from create command#366
mwbrooks merged 4 commits intomainfrom
mwbrooks-chopping-the-log-2

mwbrooks commented Mar 6, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

mwbrooks left a comment

Uh oh!

mwbrooks Mar 6, 2026

Uh oh!

mwbrooks Mar 6, 2026

Uh oh!

mwbrooks Mar 6, 2026

Uh oh!

mwbrooks Mar 6, 2026

Uh oh!

zimeg Mar 9, 2026

Uh oh!

mwbrooks Mar 9, 2026

Uh oh!

mwbrooks Mar 6, 2026

Uh oh!

zimeg left a comment

Uh oh!

zimeg Mar 9, 2026

Uh oh!

mwbrooks commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		### Formatting

		Always run `gofmt -w` on changed Go files after making edits to ensure proper formatting.

		case "on_app_create_completion":
		printProjectCreateCompletion(clients, cmd, event)

		// Notify listeners
		log.Log("info", "on_app_create_template")

Conversation

mwbrooks commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Summary

Test Steps

Requirements

Uh oh!

codecov bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mwbrooks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwbrooks commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mwbrooks commented Mar 6, 2026 •

edited

Loading

codecov bot commented Mar 6, 2026 •

edited

Loading