fix: use existing executable or unversioned python#96
Draft
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 94.68% 94.73% +0.05%
==========================================
Files 11 11
Lines 207 209 +2
==========================================
+ Hits 196 198 +2
Misses 11 11 ☔ View full report in Codecov by Sentry. |
Member
Author
|
🔍 From a Windows machine: And: |
Member
Author
|
🤖 Goodness gracious the laptop I have is out of battery. Will continue testing this later. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses the existing executable or an unversioned
pythoncommand otherwise. Fixes #70.Testing
WIP.
Special notes
These changes shouldn't break the experience for Unix, despite the
python3alias being somewhat common. I understand that this option is most relevant when creating a virtual environment, but afterward all aliases point to the same version it seems:Windows setups don't include aliases from what I find:
We might make additional changes to the upstream
initcommand if this seems correct as well:https://github.com/slackapi/slack-cli/blob/a2df7c635e6ba442f51220f6a88c57ed9b64b521/internal/runtime/python/hooks.json#L3
Requirements
./scripts/install_and_run_tests.shafter making the changes.