Skip to content

improvement(selectors): make selectorKeys declarative#3374

Merged
icecrasher321 merged 5 commits intostagingfrom
fix/webflow-resolution
Feb 27, 2026
Merged

improvement(selectors): make selectorKeys declarative#3374
icecrasher321 merged 5 commits intostagingfrom
fix/webflow-resolution

Conversation

@icecrasher321
Copy link
Collaborator

@icecrasher321 icecrasher321 commented Feb 27, 2026

Summary

  • Resolution id for webflow and teams selectors was inaccurate. Fixed here.
  • SelectorKey now part of subblock config instead of functional resolution.
  • KB tag + doc selectors were not parsing selected Kb correctly

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Feb 27, 2026 2:49pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

Fixed a critical bug where webflow selectors were not resolving correctly. The resolution logic was comparing against subBlock.id (e.g., collectionSelector, itemSelector) instead of subBlock.canonicalParamId (e.g., collectionId, itemId), causing selector routing to fail for both basic and advanced modes.

  • Updated webflow case to use canonicalParamId ?? id pattern, consistent with resolveProjectSelector implementation
  • Added block scope to webflow case for better code organization

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The fix correctly addresses a clear bug using an established pattern already present in the codebase. The change is minimal, well-scoped, and follows the same approach used in resolveProjectSelector. No logic errors or edge cases identified.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/hooks/selectors/resolution.ts Fixed webflow selector resolution to use canonicalParamId instead of id, enabling proper selector routing for both basic and advanced modes

Last reviewed commit: 451ebc5

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@icecrasher321
Copy link
Collaborator Author

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@icecrasher321 icecrasher321 changed the title fix(webflow): resolution for selectors fix(selectors): resolution for teams and webflow selectors Feb 27, 2026
@icecrasher321 icecrasher321 changed the title fix(selectors): resolution for teams and webflow selectors improvement(selectors): make selectorKeys declarative Feb 27, 2026
@icecrasher321
Copy link
Collaborator Author

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@icecrasher321
Copy link
Collaborator Author

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@icecrasher321 icecrasher321 merged commit e3ff595 into staging Feb 27, 2026
12 checks passed
@icecrasher321 icecrasher321 deleted the fix/webflow-resolution branch February 27, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant