Skip to content

doc:web: update openapi.yaml for 1.50#2554

Merged
simonmichael merged 1 commit intosimonmichael:masterfrom
n0vdd:update-openapi-1.50
Mar 2, 2026
Merged

doc:web: update openapi.yaml for 1.50#2554
simonmichael merged 1 commit intosimonmichael:masterfrom
n0vdd:update-openapi-1.50

Conversation

@n0vdd
Copy link
Copy Markdown
Contributor

@n0vdd n0vdd commented Feb 26, 2026

Update the OpenAPI specs because I wanted to try the web module and saw #2459.

@simonmichael
Copy link
Copy Markdown
Owner

Thanks for the update! I would prefer it without the CHANGES.md changes. I update those as part of the release process.

@simonmichael simonmichael added A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. web The hledger-web tool. docs Documentation-related. json hledger json output format, or JSON produced/consumed by hledger-web. and removed A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. labels Feb 26, 2026
@n0vdd
Copy link
Copy Markdown
Contributor Author

n0vdd commented Feb 28, 2026

Now is it right?

@simonmichael
Copy link
Copy Markdown
Owner

simonmichael commented Feb 28, 2026

Not quite; you have added a commit deleting CHANGES.md. You should have reverted the CHANGES.md part of the original commit and amended that commit with that reversal (it's hard to describe since there are lots of git tools). End result: a single commit just changing openapi.yaml. Perhaps easier: abandon both commits and redo the openapi one, then force-push to this PR branch.

@n0vdd n0vdd force-pushed the update-openapi-1.50 branch from 97f41d9 to 2fd9715 Compare February 28, 2026 19:32
@n0vdd
Copy link
Copy Markdown
Contributor Author

n0vdd commented Feb 28, 2026

Thank you for your patience; I am not used to doing this kind of stuff.
Now I think it is correct

@n0vdd
Copy link
Copy Markdown
Contributor Author

n0vdd commented Feb 28, 2026

One minor doubt, if you do not care: was this the correct way to update the docs, or should I have done it on the original open issue?

@simonmichael simonmichael merged commit 8affdfc into simonmichael:master Mar 2, 2026
1 check passed
@simonmichael
Copy link
Copy Markdown
Owner

Looks good - thank you! A pull request like this was the best way.

@n0vdd n0vdd deleted the update-openapi-1.50 branch March 3, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation-related. json hledger json output format, or JSON produced/consumed by hledger-web. web The hledger-web tool.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants