SF-3750 Improve import from spreadsheet error messages#3769
SF-3750 Improve import from spreadsheet error messages#3769RaymondLuong3 merged 3 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3769 +/- ##
=======================================
Coverage 81.33% 81.34%
=======================================
Files 622 622
Lines 39193 39202 +9
Branches 6399 6401 +2
=======================================
+ Hits 31879 31889 +10
+ Misses 6327 6326 -1
Partials 987 987 ☔ View full report in Codecov by Sentry. |
RaymondLuong3
left a comment
There was a problem hiding this comment.
@RaymondLuong3 reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
src/SIL.XForge.Scripture/ClientApp/src/app/checking/import-questions-dialog/import-questions-dialog.component.ts line 695 at r2 (raw file):
if (convertedData == null) { this.questionSource = 'csv_file'; this.errorState = 'invalid_spreadsheet';
Nice. I can get into this state if I upload an empty .xls file. This is a nice catch-all for files that are in a state that we did not expect and parsing fails.
Code quote:
this.errorState = 'invalid_spreadsheet';177f004 to
2285a4d
Compare
This change is