Skip to content

SF-3750 Improve import from spreadsheet error messages#3769

Merged
RaymondLuong3 merged 3 commits intomasterfrom
fix/SF-3750
Apr 2, 2026
Merged

SF-3750 Improve import from spreadsheet error messages#3769
RaymondLuong3 merged 3 commits intomasterfrom
fix/SF-3750

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented Apr 1, 2026


Open with Devin

This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Apr 1, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.34%. Comparing base (30abe0f) to head (2285a4d).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ClientApp/src/xforge-common/csv-service.service.ts 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3769   +/-   ##
=======================================
  Coverage   81.33%   81.34%           
=======================================
  Files         622      622           
  Lines       39193    39202    +9     
  Branches     6399     6401    +2     
=======================================
+ Hits        31879    31889   +10     
+ Misses       6327     6326    -1     
  Partials      987      987           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devin-ai-integration[bot]

This comment was marked as resolved.

@RaymondLuong3 RaymondLuong3 self-assigned this Apr 1, 2026
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).


src/SIL.XForge.Scripture/ClientApp/src/app/checking/import-questions-dialog/import-questions-dialog.component.ts line 695 at r2 (raw file):

      if (convertedData == null) {
        this.questionSource = 'csv_file';
        this.errorState = 'invalid_spreadsheet';

Nice. I can get into this state if I upload an empty .xls file. This is a nice catch-all for files that are in a state that we did not expect and parsing fails.

Code quote:

        this.errorState = 'invalid_spreadsheet';

@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Apr 1, 2026
@RaymondLuong3 RaymondLuong3 merged commit 216b9ff into master Apr 2, 2026
23 of 24 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/SF-3750 branch April 2, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants