Skip to content

SF-3744 Hide format options button on draft tab when draft started#3762

Merged
RaymondLuong3 merged 2 commits intomasterfrom
fix/sf-3744-formatting-options
Apr 1, 2026
Merged

SF-3744 Hide format options button on draft tab when draft started#3762
RaymondLuong3 merged 2 commits intomasterfrom
fix/sf-3744-formatting-options

Conversation

@RaymondLuong3
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 commented Mar 26, 2026

This PR updates the draft tab component to subscribe to the ProjectNotificationService to get updates on completed builds and updates the visibility of the formatting options button based on the status of the latest build. Now the component will update more quickly if a new build is started and the user should not be seeing the formatting options button.

I also removed the dead code from the draft generation page.


Open with Devin

This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Mar 26, 2026
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

devin-ai-integration[bot]

This comment was marked as resolved.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.30%. Comparing base (5330354) to head (afe5332).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...late/editor/editor-draft/editor-draft.component.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3762      +/-   ##
==========================================
+ Coverage   81.29%   81.30%   +0.01%     
==========================================
  Files         621      621              
  Lines       39114    39116       +2     
  Branches     6358     6379      +21     
==========================================
+ Hits        31798    31805       +7     
+ Misses       6344     6327      -17     
- Partials      972      984      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 force-pushed the fix/sf-3744-formatting-options branch 2 times, most recently from 78d145d to 39b4b5c Compare March 27, 2026 20:49
@pmachapman pmachapman self-assigned this Mar 29, 2026
@pmachapman pmachapman self-requested a review March 29, 2026 20:36
@pmachapman pmachapman added the e2e Run e2e tests for this pull request label Mar 29, 2026
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thank you for pruning the old code, I have been meaning to do this for a while!

@pmachapman reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on RaymondLuong3).

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Mar 29, 2026
@RaymondLuong3 RaymondLuong3 force-pushed the fix/sf-3744-formatting-options branch from 39b4b5c to afe5332 Compare April 1, 2026 15:32
@RaymondLuong3 RaymondLuong3 merged commit da92e59 into master Apr 1, 2026
24 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/sf-3744-formatting-options branch April 1, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request ready to test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants