Open
Conversation
Args.dll (needed for GeckofxHtmlToPdf) was not being copied during the build after .NET modernizations. Also include harvests in patch logs to make this type of omission easier to troubleshoot in the future. Also fix whitespace and build instructions in Setup-InstallerBuild.ps1
* Fix a garbled comment * Remove redundant -BuildTests flag (implied by -RunTests) * Ignore test residue
Of course downloaded files don't exist when the targets file containing downloadDLLs is loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Download and copy DLLs during the build so that they are included in the installer.
Args.dll (needed for GeckofxHtmlToPdf) was not being copied during the build after .NET modernizations. It was also
Also
Notes for reviewers (optional)
It is possible that calling
CopyDLLsfrom NativeBuild.csproj is unnecessary; I expect we were somehow calling it in two separate MSBuild calls before I removed the redundant FW build from the installer build. I can investigate that tomorrow.This change is