python(refactor): port grpc transport modules into sift_client#487
Open
python(refactor): port grpc transport modules into sift_client#487
Conversation
Contributor
Author
|
Working on fixing the ruff check errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
sift_clientwas depending onsift_pyinternals for its gRPC transport layer (e.g.,grpc_transport.pywas importingSiftChannelConfiganduse_sift_async_channeldirectly fromsift_py/grpc. Sincesift_pyis being deprecated, this dependency should be removed andsift_clientshould be self-contained.The gRPC transport modules were ported from
sift_py/grpctosift_client/_internal/grpc/, keeping the same structure.grpc_transport.pywas then updated to import from the new internal location instead ofsift_py(keepingsift_pyuntouched).Verification
Ran
transport_test.pymanually against the new internal modules and both tests passed. Manually tested the connection through a local script using the library, verifying theSiftClientconnection.