Skip to content

python(refactor): port grpc transport modules into sift_client#487

Open
wei-qlu wants to merge 3 commits intomainfrom
python/migrate-grpc-modules-to-sift-client
Open

python(refactor): port grpc transport modules into sift_client#487
wei-qlu wants to merge 3 commits intomainfrom
python/migrate-grpc-modules-to-sift-client

Conversation

@wei-qlu
Copy link
Contributor

@wei-qlu wei-qlu commented Mar 4, 2026

What changed

sift_client was depending on sift_py internals for its gRPC transport layer (e.g., grpc_transport.py was importing SiftChannelConfig and use_sift_async_channel directly from sift_py/grpc. Since sift_py is being deprecated, this dependency should be removed and sift_client should be self-contained.

The gRPC transport modules were ported from sift_py/grpc to sift_client/_internal/grpc/, keeping the same structure. grpc_transport.py was then updated to import from the new internal location instead of sift_py (keeping sift_py untouched).

Verification

Ran transport_test.py manually against the new internal modules and both tests passed. Manually tested the connection through a local script using the library, verifying the SiftClient connection.

Screenshot 2026-03-04 at 11 08 53 AM

@wei-qlu wei-qlu requested a review from solidiquis March 4, 2026 19:10
@wei-qlu
Copy link
Contributor Author

wei-qlu commented Mar 4, 2026

Working on fixing the ruff check errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant