chore(deps): update hardhat packages (major)#191
Conversation
package.json
Outdated
| "@nomicfoundation/hardhat-toolbox-viem": "5.0.1", | ||
| "@nomiclabs/hardhat-solhint": "4.1.0", | ||
| "hardhat": "2.26.5", | ||
| "hardhat": "3.0.11", |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
1434eee to
47e4ec1
Compare
47e4ec1 to
36cfcc5
Compare
4e7734f to
373851f
Compare
373851f to
657200c
Compare
package.json
Outdated
| "@nomicfoundation/hardhat-ignition-viem": "0.15.16", | ||
| "@nomicfoundation/hardhat-toolbox-viem": "4.1.1", | ||
| "@nomicfoundation/hardhat-ignition-viem": "3.0.6", | ||
| "@nomicfoundation/hardhat-toolbox-viem": "5.0.1", |
There was a problem hiding this comment.
Bug: The update to @nomicfoundation/hardhat-toolbox-viem introduces peer dependency conflicts. Several related @nomicfoundation packages are not updated to the required major version.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
Updating @nomicfoundation/hardhat-toolbox-viem to 5.0.1 requires several peer dependencies like @nomicfoundation/hardhat-network-helpers and @nomicfoundation/hardhat-viem to be at version ^3.0.0. However, the lockfile indicates that older, incompatible versions (e.g., 1.1.2, 2.1.3) are still in use. This mismatch will likely lead to installation warnings or failures with npm/bun, and could cause runtime errors due to API incompatibilities between major versions if the installation succeeds.
💡 Suggested Fix
Update all related @nomicfoundation packages in package.json to their required major versions (^3.0.0) to satisfy the peer dependencies of @nomicfoundation/hardhat-toolbox-viem@5.0.1. After updating package.json, run the package manager's install command to regenerate the lockfile.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L41
Potential issue: Updating `@nomicfoundation/hardhat-toolbox-viem` to `5.0.1` requires
several peer dependencies like `@nomicfoundation/hardhat-network-helpers` and
`@nomicfoundation/hardhat-viem` to be at version `^3.0.0`. However, the lockfile
indicates that older, incompatible versions (e.g., `1.1.2`, `2.1.3`) are still in use.
This mismatch will likely lead to installation warnings or failures with `npm`/`bun`,
and could cause runtime errors due to API incompatibilities between major versions if
the installation succeeds.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6983511
package.json
Outdated
| "@nomicfoundation/hardhat-ignition-viem": "3.0.6", | ||
| "@nomicfoundation/hardhat-toolbox-viem": "5.0.1", | ||
| "@nomiclabs/hardhat-solhint": "4.1.0", | ||
| "hardhat": "2.27.1", | ||
| "hardhat": "3.1.0", |
There was a problem hiding this comment.
Bug: The hardhat.config.ts file has not been updated for Hardhat 3's new plugin system, which will cause plugins to fail to load and tests to crash.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The upgrade to Hardhat 3.1.0 introduces a breaking change in how plugins are loaded. The hardhat.config.ts file still uses the old Hardhat 2 method of importing plugins for their side effects. The new required method is to explicitly list plugins in a plugins array within a defineConfig call. Because the plugins are not loaded correctly, extensions to the Hardhat Runtime Environment, such as hre.viem, will be undefined. This will cause tests calling hre.viem.deployContract() to fail with a TypeError.
💡 Suggested Fix
Refactor hardhat.config.ts to use the defineConfig function from hardhat/config. Import the plugins directly and list them in the plugins array within the configuration object. This will ensure they are loaded correctly by Hardhat 3.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L40-L43
Potential issue: The upgrade to Hardhat 3.1.0 introduces a breaking change in how
plugins are loaded. The `hardhat.config.ts` file still uses the old Hardhat 2 method of
importing plugins for their side effects. The new required method is to explicitly list
plugins in a `plugins` array within a `defineConfig` call. Because the plugins are not
loaded correctly, extensions to the Hardhat Runtime Environment, such as `hre.viem`,
will be `undefined`. This will cause tests calling `hre.viem.deployContract()` to fail
with a `TypeError`.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6983511
1a875a2 to
3c6bdd2
Compare
cb5bc81 to
fbd52d8
Compare
fbd52d8 to
270028d
Compare
68f12fb to
6715241
Compare
6715241 to
7c2691e
Compare
8587603 to
58d5967
Compare
58d5967 to
d06e249
Compare
b11d714 to
82389f6
Compare
13dd2d8 to
449d686
Compare
449d686 to
ec185a6
Compare
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ec185a6 to
1a11c14
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
This PR contains the following updates:
1.2.0→3.0.00.15.16→3.1.14.1.1→5.0.34.1.0→5.0.02.27.1→3.3.0Release Notes
NomicFoundation/hardhat (@nomicfoundation/hardhat-foundry)
v3.0.0Compare Source
Major Changes
4cd63e9: Introduce the@nomicfoundation/hardhat-foundryplugin for Hardhat 3v1.2.1Compare Source
NomicFoundation/hardhat (@nomicfoundation/hardhat-ignition-viem)
v3.1.1Compare Source
Changes
#8088
23c0d36Thanks @alcuadrado! - Optimize imports.Updated dependencies:
v3.1.0Compare Source
Minor Changes
481b221Thanks @manuelwedler! - Added support for verifying on all enabled verification services (e.g. Sourcify) (#7538).Patch Changes
v3.0.9Compare Source
Patch Changes
2cbf218: Fix an issue that prevented the verification of contracts using FQNs (#8014)13918b4: Add support for custom chains not in viem's built-in chain list, thanks @daanporon! (#7763)v3.0.8Compare Source
Patch Changes
6674b00: Bumphardhat-utilsmajorv3.0.7Compare Source
Patch Changes
2bc18b2: Bumpedviemversion across all packages 7861.v3.0.6Compare Source
Patch Changes
dac916b: Expose ignition retry loop variables in user config (Hardhat v3) (#7303)v3.0.5Compare Source
Patch Changes
d1c1803: Make@nomicfoundation/hardhat-ignition's UI work well with other plugins, like Ledger's.v3.0.4Compare Source
Patch Changes
843c1ae: Fixed a bug preventing Ignition from using thehre.config.ignitionsettings when deploying via script (#7641)558ac5b: Update installation and config instructionsv3.0.3Compare Source
Patch Changes
bebf87c: Added support for Linea network verification, thanks @kyzooghost (#7357)v3.0.2Compare Source
Patch Changes
ddefbff: Added guard to stop multiple simultaneous calls toignition.deploy(...)at once (#6440)v3.0.1Compare Source
Patch Changes
86cecc7: Fix the type guard to includem.encodeFunctionCallin those that do not submit transactions, thanks @radik878 (#7264)v3.0.0Compare Source
Major Changes
29cc141: First release of Hardhat 3!NomicFoundation/hardhat (@nomicfoundation/hardhat-toolbox-viem)
v5.0.3Compare Source
Patch Changes
13918b4: Add support for custom chains not in viem's built-in chain list, thanks @daanporon! (#7763)v5.0.2Compare Source
Patch Changes
2bc18b2: Bumpedviemversion across all packages 7861.v5.0.1Compare Source
Patch Changes
558ac5b: Update installation and config instructionsv5.0.0Compare Source
Major Changes
29cc141: First release of Hardhat 3!v4.1.2Compare Source
This release is a small bump to the version of
solidity-coverageto include changes for the Osaka transaction gas limit.Changes
a7e4215: Update solidity-coverage minimum version to include Osaka changesNomicFoundation/hardhat (@nomiclabs/hardhat-solhint)
v5.0.0Compare Source
v4.1.2Compare Source
v4.1.1Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.