Major benchmark.py and synthesizers/ update#575
Open
exemburg wants to merge 3 commits intosdv-dev:mainfrom
Open
Major benchmark.py and synthesizers/ update#575exemburg wants to merge 3 commits intosdv-dev:mainfrom
exemburg wants to merge 3 commits intosdv-dev:mainfrom
Conversation
Replaced import-time side effects with registersdvsynthesizers, added lazy registration and optional dependency handling.
Introduced Modality enum, abc.abstractmethod enforcement, clearer typing and metadata handling. Improvements: contract safety and static analysis readability and testability
Vectorized sampling, deterministic GMM settings, guards for edge cases and NaNs, better logging. - Improvements: runtime performance and reproducibility robustness for dirty/small datasets maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored SDGym to centralize tunables (ConfigTunables), encapsulate memory tracing (MemoryTracker), and lazy‑register SDV synths to eliminate import‑time side effects; added stronger typing, docstrings, a Modality enum and abstract method contracts; made synthesizer handling immutable (copy before mutate), standardized pathlib usage, and improved S3 handling with a lazy boto3 client, timeouts/retries and safer metainfo logic; scoped tracemalloc and synthesizer size measurement, made sampling deterministic (GMM randomstate, ninit) and vectorized, guarded edge cases/NaNs, removed private API reliance, improved logging and error messages, returned plain dicts from I/O helpers, and prepared the code for safer multiprocessing, better timeout/termination, CI tests, and overall improved reliability, performance, reproducibility, and maintainability.