Fix FutureWarning for na_action in Categorical.map#541
Closed
Conversation
Explicitly pass `na_action="ignore"` to `Categorical.map()` to silence the FutureWarning introduced in pandas 2.1. This preserves the existing behavior with no functional change, as the mapper is always a dict. Closes #540 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
=======================================
Coverage 83.96% 83.96%
=======================================
Files 9 9
Lines 2595 2595
=======================================
Hits 2179 2179
Misses 416 416
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FutureWarningfrom pandas ≥2.1 about the deprecated defaultna_actionparameter inCategorical.map()by explicitly passingna_action="ignore"dict(never a callable), sona_actionhas no effect on behavior — this is a pure warning suppression with zero functional changeCloses #540
Test plan
🤖 Generated with Claude Code